Update Homebrew installation to use spinframework tap #37
Conversation
Signed-off-by: Kate Goldenring <[email protected]>
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
LGTM, just one double-check on older versions
| <!-- @selectiveCpy --> | ||
|
|
||
| ```bash | ||
| $ brew tap fermyon/tap |
There was a problem hiding this comment.
Sanity check that it's correct to use the new tap for old (v1 and v2) versions
There was a problem hiding this comment.
With brew you can't use old versions of Spin -- rather you can only pull latest. People using older Spin will be on the fermyon tap still. I'm not sure what is best here. Happy to update
There was a problem hiding this comment.
Thanks for explaining! No need to change!
Signed-off-by: Kate Goldenring <[email protected]>
vdice
left a comment
vdice
left a comment
There was a problem hiding this comment.
Thank you @kate-goldenring!
content/v1/install.md
Outdated
| $ brew install spinframework/tap/spin | ||
| ``` | ||
|
|
||
| > Note: `brew install spin` will **not** install the Spin framework. Spin is accessed from the `fermyon` tap, as shown above. |
There was a problem hiding this comment.
Oops, sorry, just noticed this one; can we update "fermyon tap" to "spinframework tap" here and in the other spots?
There was a problem hiding this comment.
@vdice this was my thought process around v1 and v2 #37 (comment)
There was a problem hiding this comment.
Oh I just meant can we replace "Spin is accessed from the fermyon tap" on line 48 with "Spin is accessed from the spinframework tap"?
There was a problem hiding this comment.
oh nice! Thanks! Yes.
There was a problem hiding this comment.
updated! Thanks for catching this!
Signed-off-by: Kate Goldenring <[email protected]>
3 participants
closes #26